fix: disable metadata export for APIP #2507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomiejmarszal
requested review from
tikhanovichA,
pnal and
Karol-Stelmaczonek
pnal
approved these changes
May 30, 2024
tikhanovichA
approved these changes
May 30, 2024
|
|
||
| //APIP does not support metadata at this moment | ||
| if(!isset($options['apip']) && $options['apip'] !== true){ |
There was a problem hiding this comment.
Shouldn it be OR instead of AND ? If apip is not set OR apip has value false ? Then do metadata stuff?
There was a problem hiding this comment.
Both conditions are required. First if apip is not set you should go into if block. And if it is set it should be other than true to enter block. If I use OR it can lead engine to check both conditions and in second condition if it is not set it will cause fatal error.
Front-end summary Node 18
|
Karol-Stelmaczonek
approved these changes
May 31, 2024
Version
There are 0 BREAKING CHANGE, 0 feature, 3 fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exporting APIP package, disable metadata export.
Metadata export for APIP will be developed soon so it will be enabled.
How to test:
Expected behavior
Item APIP package does not contain metadata.
Importing APIP Package is successful.