Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL-1884: Delivery cannot be published when test contains Item with rich passages #2625

Merged

Conversation

vbyndych
Copy link
Contributor

@vbyndych vbyndych commented Nov 18, 2024

Related to: https://oat-sa.atlassian.net/browse/REL-1884

Steps to reproduce:

  1. Go to "Deliveries" page
  2. Click "New delivery" button below the Deliveries tree
  3. Enter the title of Test from preconditions in the "Select the test" field (3 or more characters)
  4. Click "Publish" button

The issue was connected to the interface change in the \League\Flysystem\ProxyArrayAccessToProperties::offsetSet. In the new version, it doesn't allow you to set new or change an existing property of the object and throws an exception in case you try to do it.

…s or changing existing, updated our logic accordingly.
Copy link
Contributor

@yaraslau-kavaliou yaraslau-kavaliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbyndych vbyndych merged commit 57c6408 into feat/REL-1723/update-flysystem Nov 19, 2024
@vbyndych vbyndych deleted the fix/REL-1884/flysystem-styles-loader branch November 19, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants