-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/aut 3942/custom response processing ux update #2648
Merged
viktar-dzmitryieu-tao
merged 5 commits into
develop
from
feature/AUT-3942/custom-response-processing-ux-update
Dec 24, 2024
Merged
Feature/aut 3942/custom response processing ux update #2648
viktar-dzmitryieu-tao
merged 5 commits into
develop
from
feature/AUT-3942/custom-response-processing-ux-update
Dec 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Front-end summary Node 18
|
viktar-dzmitryieu-tao
requested review from
a team,
tikhanovichA,
KirylHatalski,
Karol-Stelmaczonek and
jsconan
and removed request for
a team
December 17, 2024 12:47
jsconan
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick code review. I didn't look very deep, but the approach is good.
Karol-Stelmaczonek
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
Version
There are 0 BREAKING CHANGE, 0 feature, 4 fixes |
tikhanovichA
approved these changes
Dec 20, 2024
viktar-dzmitryieu-tao
deleted the
feature/AUT-3942/custom-response-processing-ux-update
branch
December 24, 2024 14:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://oat-sa.atlassian.net/browse/AUT-3991
What's Changed
Common interactions
How to test
Common interactions
in the Custom response processing modeThe changes are deployed to: https://test-viktar-authoring.v3.playground.taocloud.org/tao/Main/login