Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/aut 3942/custom response processing ux update #2648

Conversation

viktar-dzmitryieu-tao
Copy link
Contributor

@viktar-dzmitryieu-tao viktar-dzmitryieu-tao commented Dec 17, 2024

Ticket: https://oat-sa.atlassian.net/browse/AUT-3991

What's Changed

  • Updated the existing logic of applying custom response processing for all Common interactions
  • The overlay for all common interactions in state of custom response processing is removed
  • User can interact with the widget and is able to change the response when it is in Custom response processing mode
  • Updated response is saved (when it is in Custom response processing mode)
  • Processing Rules are not changed/affected by user actions on changing the response itself
  • All other existing behaviour/business logic is not affected

How to test

  • Check any/all Common interactions in the Custom response processing mode

The changes are deployed to: https://test-viktar-authoring.v3.playground.taocloud.org/tao/Main/login

Copy link

github-actions bot commented Dec 17, 2024

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
287 287 0 0

@viktar-dzmitryieu-tao viktar-dzmitryieu-tao requested review from a team, tikhanovichA, KirylHatalski, Karol-Stelmaczonek and jsconan and removed request for a team December 17, 2024 12:47
Copy link
Contributor

@jsconan jsconan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick code review. I didn't look very deep, but the approach is good.

Copy link
Contributor

@Karol-Stelmaczonek Karol-Stelmaczonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

Copy link

Version

Target Version 30.25.3
Last version 30.25.2

There are 0 BREAKING CHANGE, 0 feature, 4 fixes

@viktar-dzmitryieu-tao viktar-dzmitryieu-tao merged commit f89676a into develop Dec 24, 2024
5 checks passed
@viktar-dzmitryieu-tao viktar-dzmitryieu-tao deleted the feature/AUT-3942/custom-response-processing-ux-update branch December 24, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants