Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/rel 1275/script create lti platform #386

Merged
merged 7 commits into from
Oct 9, 2023

Conversation

augustas
Copy link
Contributor

@augustas augustas commented Sep 25, 2023

Script to create an Lti Platform, that could be used in the seed as a post install script.

Related to : https://oat-sa.atlassian.net/browse/REL-1275

How to test

  • Run the command php index.php "\oat\taoLti\scripts\tools\SetupLtiPlatform" --label TestPlatform --client_id test-client-id-1 --deployment_id 1 --audience https://foo.bar --token_url http://foo.bar --oidc_url http://foo.bar --jwks_url https://foo.bar
  • Verify in the backoffice Lti 1.3 Platform view that the record was created
  • Test that it is possible to launch to TAO with the newly configured platform

@augustas augustas requested a review from vbyndych September 25, 2023 14:39
Copy link
Contributor

@vbyndych vbyndych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Checklist

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code respects code style rules
  • New code respects best practices
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic

scripts/tools/SetupLtiPlatform.php Outdated Show resolved Hide resolved
scripts/tools/SetupLtiPlatform.php Outdated Show resolved Hide resolved
@vbyndych vbyndych self-assigned this Oct 2, 2023
Co-authored-by: Vlad Byndych <vladyslav.byndych@taotesting.com>
Signed-off-by: Augustas <augustas.nedzinskas@gmail.com>
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8dffc0b) 30.59% compared to head (54f5ec8) 30.59%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #386   +/-   ##
==========================================
  Coverage      30.59%   30.59%           
  Complexity       817      817           
==========================================
  Files            104      104           
  Lines           2853     2853           
==========================================
  Hits             873      873           
  Misses          1980     1980           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Version

❕ Some commits are not using the conventional commits formats. They will be ignored in version management.

Target Version 15.14.0
Last version 15.13.4

There are 0 BREAKING CHANGE, 1 feature, 4 fixes

@augustas augustas merged commit 5b8b02f into develop Oct 9, 2023
4 checks passed
@augustas augustas deleted the feat/REL-1275/script-create-lti-platform branch October 9, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants