-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: publish to two solar tenants #398
Merged
mccar
merged 12 commits into
feat/REL-1466/publish-to-two-solar-tenants
from
feat/REL-1466/nccer-publish-to-two-solar-tenants
Mar 4, 2024
Merged
feat: publish to two solar tenants #398
mccar
merged 12 commits into
feat/REL-1466/publish-to-two-solar-tenants
from
feat/REL-1466/nccer-publish-to-two-solar-tenants
Mar 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #398 +/- ##
=============================================
+ Coverage 30.35% 31.14% +0.79%
- Complexity 827 832 +5
=============================================
Files 106 106
Lines 2906 2922 +16
=============================================
+ Hits 882 910 +28
+ Misses 2024 2012 -12 ☔ View full report in Codecov by Sentry. |
mccar
requested review from
augustas,
vbyndych,
olegkhuss and
yaraslau-kavaliou
February 28, 2024 08:35
augustas
reviewed
Feb 28, 2024
models/classes/Security/DataAccess/Repository/PlatformKeyChainRepository.php
Outdated
Show resolved
Hide resolved
vbyndych
requested changes
Feb 29, 2024
test/unit/models/classes/Security/DataAccess/Repository/PlatformJwksRepositoryTest.php
Outdated
Show resolved
Hide resolved
models/classes/Security/DataAccess/Repository/PlatformKeyChainRepository.php
Outdated
Show resolved
Hide resolved
models/classes/Security/DataAccess/Repository/PlatformKeyChainRepository.php
Outdated
Show resolved
Hide resolved
Version
There are 0 BREAKING CHANGE, 12 features, 0 fix |
mccar
changed the base branch from
develop
to
feat/REL-1466/publish-to-two-solar-tenants
March 4, 2024 14:21
mccar
changed the title
feat: NCCER publish to two solar tenants
feat: publish to two solar tenants
Mar 4, 2024
mccar
merged commit Mar 4, 2024
638b220
into
feat/REL-1466/publish-to-two-solar-tenants
1 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket - https://oat-sa.atlassian.net/browse/REL-1466
Related to - oat-sa/tao-core#3968
Goal
NCCER publish to two solar tenants
Changelog
How to test
or use the tools command to generate a key and add configuration