fix: Neo4j - impossible to save or author passage due to language property erased when "Save" button is clicked in "Edit Passage Properties" #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perty erased when "Save" button is clicked in "Edit Passage Properties"
mccar
changed the title
|
|
||
| public function down(Schema $schema): void | ||
| { | ||
| // do nothing |
There was a problem hiding this comment.
Maybe throw this exception here as it cannot be reverted:
throw new IrreversibleMigration('Reverting this migration does not make sense');
vbyndych
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code respects code style rules
- New code respects best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
…perty erased when "Save" button is clicked in "Edit Passage Properties"
Version
There are 0 BREAKING CHANGE, 0 feature, 2 fixes |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #494 +/- ##
==========================================
Coverage 37.64% 37.64%
Complexity 797 797
==========================================
Files 96 96
Lines 2882 2882
==========================================
Hits 1085 1085
Misses 1797 1797 ☔ View full report in Codecov by Sentry. |
mccar
deleted the
fix/AUT-3382/neo4j-impossible-to-save-author-passage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket - https://oat-sa.atlassian.net/browse/AUT-3382
Goal
Fix issue with language on edit passage properties
Changelog
How to test
After update and apply migrations try to edit form