feature AUT-2510_remove-ie-support #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated tao-test-runner in order to include removal of IE11 support
Version
There are 0 BREAKING CHANGE, 1 feature, 0 fix |
yukipastelcat
requested review from
krampstudio,
btamas,
jsconan,
oatymart and
shaveko
btamas
changed the title
btamas
reviewed
Jul 21, 2022
| @@ -10,6 +10,6 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@oat-sa/tao-item-runner": "0.8.1", | |||
| "@oat-sa/tao-test-runner": "0.8.2" | |||
| "@oat-sa/tao-test-runner": "^0.9.0" | |||
There was a problem hiding this comment.
As I see, we used exact version in the package.json. Maybe we should continue, even if I don't understand why we did it.
jsconan
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
Works fine. I did not find visible regression from a quick test across TAO
Review Checklist
-
New code is covered by tests (if applicable) - Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
-
New code is not subject to concurrency issues (if applicable) - Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request summary
Related to AUT-2510.
Updated @oat-sa/tao-test-runner and in order to include removal of IE support
How to test
Use http://playground.kitchen.it.taocloud.org/?p=test-ie-support-removal_delivery.git;a=summary to test changes
Checklist