Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: apply PSR-12 #442

Merged
merged 2 commits into from
May 4, 2023
Merged

chore: apply PSR-12 #442

merged 2 commits into from
May 4, 2023

Conversation

shpran
Copy link
Contributor

@shpran shpran commented May 3, 2023 •
edited by jira bot
Loading

@codecov-commenter
Copy link

Codecov Report

Merging #442 (858dbe8) into develop (9f00b4d) will increase coverage by 3.61%.
The diff coverage is 46.55%.

@@              Coverage Diff              @@
##             develop     #442      +/-   ##
=============================================
+ Coverage       6.47%   10.09%   +3.61%     
- Complexity       250      261      +11     
=============================================
  Files             31       33       +2     
  Lines            633      743     +110     
=============================================
+ Hits              41       75      +34     
- Misses           592      668      +76
Impacted Files Coverage Δ
actions/class.RestTests.php 0.00% <ø> (ø)
actions/class.SaSTests.php 0.00% <ø> (ø)
actions/class.TestExport.php 0.00% <ø> (ø)
models/classes/class.CrudTestsService.php 0.00% <ø> (ø)
models/classes/class.TestCompiler.php 0.00% <ø> (ø)
models/classes/class.TestsService.php 0.00% <0.00%> (ø)
models/classes/event/TestChangedEvent.php 0.00% <ø> (ø)
models/classes/event/TestCreatedEvent.php 0.00% <ø> (ø)
models/classes/event/TestDuplicatedEvent.php 30.00% <ø> (+30.00%) ⬆️
models/classes/event/TestExecutionPausedEvent.php 0.00% <ø> (ø)
... and 15 more

... and 2 files with indirect coverage changes

@shpran shpran requested a review from gabrielfs7 May 4, 2023 14:08
@shpran shpran marked this pull request as ready for review May 4, 2023 14:08
@github-actions
Copy link

github-actions bot commented May 4, 2023

Version

Target Version 15.16.1
Last version 15.16.0

There are 0 BREAKING CHANGE, 0 feature, 0 fix

gabrielfs7
gabrielfs7 approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@gabrielfs7 gabrielfs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved code style and formatting changes

@shpran shpran merged commit 406d395 into develop May 4, 2023
@shpran shpran deleted the feature/ADF-1440/psr-12-apply branch May 4, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielfs7 gabrielfs7 gabrielfs7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shpran @codecov-commenter @gabrielfs7