Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/core 5.0.0 #17

Merged
merged 4 commits into from
Apr 1, 2021
Merged

Feature/core 5.0.0 #17

merged 4 commits into from
Apr 1, 2021

Conversation

ekkinox
Copy link
Contributor

@ekkinox ekkinox commented Apr 1, 2021

  • Added psalm support
  • Deleted MembershipServiceServer in favor to MembershipServiceServerRequestHandler (to be used with core LtiServiceServer)
  • Updated oat-sa/lib-lti1p3-core dependency to version 5.0
  • Updated MembershipServiceServerBuilderInterface parameters to work with registration
  • Updated MembershipServiceClient (to work with core LtiServiceClient)
  • Updated overall constructors to handle nullable parameters
  • Updated documentation

target release: 5.0.0

ekkinox added 3 commits April 1, 2021 10:57
feat: reworked NRPS server using the core LtiServiceServer
feat: added registration as builder parameter
feat: added psalm
chore: updated tests and documentation
chore: updated overall constructors for nullable parameters
fix: fixed psalm issues
feat: added psalm to travis builds
feat: provided changelog entry
Copy link

@siwane siwane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@ekkinox ekkinox requested a review from GregoryGagua April 1, 2021 10:08
@ekkinox ekkinox merged commit 6d46c61 into develop Apr 1, 2021
@ekkinox ekkinox deleted the feature/core-5.0.0 branch April 1, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants