feature: legacy TR-1499 html5+figure/figcaption support #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnal
changed the title
kilatib
requested changes
May 30, 2022
test/qtismtest/data/content/xhtml/html5/Html5LayoutElementTest.php
Outdated
Show resolved
Hide resolved
test/qtismtest/data/storage/xml/marshalling/Html5LayoutMarshallerTest.php
Outdated
Show resolved
Hide resolved
kilatib
reviewed
Jun 1, 2022
kilatib
reviewed
Jun 1, 2022
kilatib
reviewed
Jun 1, 2022
kilatib
reviewed
Jun 1, 2022
kilatib
reviewed
Jun 1, 2022
kilatib
reviewed
Jun 1, 2022
kilatib
reviewed
Jun 1, 2022
kilatib
reviewed
Jun 1, 2022
pnal
changed the title
This was referenced Jun 1, 2022
andreluizmachado
requested changes
Jun 2, 2022
| return static::asArray()[$name] ?? false; | ||
| } | ||
|
|
||
| public static function getNameByConstant($constant) |
There was a problem hiding this comment.
can we add return typehint here?
There was a problem hiding this comment.
no because we do not have such type string|false
test/qtismtest/data/storage/xml/marshalling/Html5LayoutMarshallerTest.php
Outdated
Show resolved
Hide resolved
test/qtismtest/data/storage/xml/marshalling/Html5LayoutMarshallerTest.php
Outdated
Show resolved
Hide resolved
test/qtismtest/data/storage/xml/marshalling/Html5LayoutMarshallerTest.php
Outdated
Show resolved
Hide resolved
andreluizmachado
approved these changes
Jun 9, 2022
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Changelog is updated according to changes (if applicable)
- Documentation is updated according to changes (if applicable)
kilatib
reviewed
Jun 10, 2022
| protected $content; | ||
|
|
||
| /** | ||
| * @param string|null $title A title in the sense of Html title attribute |
There was a problem hiding this comment.
not to require but params could be removed because described in a function head
kilatib
reviewed
Jun 10, 2022
| /** | ||
| * @param DOMElement $element | ||
| * @param QtiComponentCollection $children | ||
| * @return mixed |
kilatib
reviewed
Jun 10, 2022
| /** | ||
| * Checks that the given value is null or one of the enumeration constants. | ||
| * | ||
| * @param int|string|null $value |
There was a problem hiding this comment.
Not required; params could be removed because described in function head
kilatib
approved these changes
Jun 10, 2022
julien-sebire
deleted the
feature/legacy/TR-1499/support_qti_figure_figcaption_elements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TR-1499
Marshalling/unmarshalling HTML5 figure&figcaption elements
Related PRs:
https://github.com/oat-sa/extension-tao-deliver-connect/pull/125
oat-sa/extension-tao-itemqti#2138