fix: AssessmentItem::setIdentifier uses isNormalizedString #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomiejmarszal
requested review from
tikhanovichA,
bugalot,
pnal and
julien-sebire
bugalot
requested changes
Jul 11, 2024
|
We would like to also see the backport coming, otherwise we will for sure forget. I would strongly suggest to merge this in |
|
OK, now I understand, it's the fix on the legacy version. However, please update the unit tests as well, so that it goes along that version too. |
tikhanovichA
approved these changes
Jul 12, 2024
bartlomiejmarszal
deleted the
fix/AUT-3705/backport-use-normalised-string-in-item-identifier
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow to set identifier that is validated against normalized string