Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/broken cli #408

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Fix/broken cli #408

wants to merge 5 commits into from

Conversation

bugalot
Copy link
Contributor

@bugalot bugalot commented Nov 22, 2024

This PR aims at fixing the render command of the CLI.

  • It includes an update of library wp-cli/php-cli-tools to version 0.12.1.
  • It also include a fix for a previous change that made the render command broken.
  • Makes possible to use relative paths as CLI argument.

In order to test, invoke from CLI the following command which should not return any error.

./bin/qtisdk render -df --source test/samples/ims/items/2_1_1/choice.xml --flavour goldilocks

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.23%. Comparing base (2776840) to head (bb879f9).
Report is 88 commits behind head on develop.

Files with missing lines Patch % Lines
src/qtism/cli/Render.php 0.00% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #408      +/-   ##
=============================================
- Coverage      91.37%   91.23%   -0.15%     
+ Complexity     10465    10306     -159     
=============================================
  Files            947      947              
  Lines          26102    26182      +80     
=============================================
+ Hits           23852    23887      +35     
- Misses          2250     2295      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant