Feature/TR-5209/Cleanup calculator engine #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
shaveko
approved these changes
Apr 13, 2023
rgomeztao
approved these changes
Apr 13, 2023
This was referenced Apr 14, 2023
Version🚨 Your pull request contains a BREAKING CHANGE, please be sure to communicate it.
There are 1 BREAKING CHANGE, 2 features, 0 fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://oat-sa.atlassian.net/browse/TR-5209
Requires:
Summary
Remove dependencies used by the calculator since it has moved to a dedicated package: tao-calculator
BREAKING CHANGE
The packages that rely on this component need to now use
tao-calculatorDetails
Remove the
mathsEvaluatorand its dependencies.How to test
npm inpm test