Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replaced - and _ characters in jwt #172

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

peetya
Copy link
Contributor

@peetya peetya commented Jun 19, 2023

atob doesn't support the following special characters: - and _.

- must be replaced with + and _ must be replaced with / characters.

@github-actions
Copy link

Version

Target Version 2.0.2
Last version 2.0.1

There are 0 BREAKING CHANGE, 0 feature, 1 fix

@github-actions
Copy link

Coverage Report

Totals Coverage
Statements: 90.79% ( 2592 / 2855 )
Methods: 95.19% ( 594 / 624 )

Copy link
Contributor

@jsconan jsconan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Checklist

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code respects code style rules
  • New code respects best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic

@peetya peetya merged commit b41d5ef into develop Jun 20, 2023
@peetya peetya deleted the fix/RFE-281/replace-jwt-unsupported-characters branch June 20, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants