Upgrade lodash to 4.17.21 #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated lodash dependency - Updated changed lodash methods BREAKING CHANGE: updated lodash dependency to 4.17.21
BREAKING CHANGE: upgraded tao-core-libs to 1.0.0, lodash@4 is required as peerDependency
- Replaced _.where with _.filter according to [deprecation guidelines](https://github.com/lodash/lodash/wiki/Deprecations)
yukipastelcat
requested review from
btamas,
marpesia,
ViktoriaKh-oat,
jsconan and
oatymart
btamas
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Update looks good, tests are running with PARALLEL_TESTS=1 npm run test
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
- Changelog is updated according to changes (if applicable)
- Documentation is updated according to changes (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://oat-sa.atlassian.net/browse/AUT-1391
What's Changed
--lockfile-version 1flag to avoid changing lockfile structureBREAKING CHANGE: updated lodash dependency to 4.17.21, updated tao-core-libs to 1.0.0 which requires lodash@4.17.21 installed as peer dependency
Dependencies PRs
How to test
npm run buildin order to check that build isn't brokennpm testto check qunit-testrunner tests