Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/trn 28/improve network errors #83
Feature/trn 28/improve network errors #83
Changes from all commits
f420ced
180df47
9e01d6f
674f001
afee254
5ec3921
471de30
d2f46c3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks correct API-wise, but since there is no standard, I didn't see how we could ever benefit from the extra
...params
passed through.As you said, in Firefox they map onto properties like
lineNumber
,fileName
, but it's proprietary, Safari doesn't do anything with such params.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen in other implementations fallback to
this.stack = (new Error()).stack
ifError.captureStackTrace
is not supportedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error.captureStackTrace
is only used in node.js (so the stack trace appears in the unit tests when failing).By default, the stack will be captured by inheriting from the
Error
type, it is generated by the constructor. The implementation should be identical cross browser once handled by Babel.