Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/tr 652 credential support for jwttokenhandler #89

Merged
merged 10 commits into from
Feb 24, 2021
Merged

Feature/tr 652 credential support for jwttokenhandler #89

merged 10 commits into from
Feb 24, 2021

Conversation

btamas
Copy link
Contributor

@btamas btamas commented Feb 19, 2021 •
edited
Loading

Related to https://oat-sa.atlassian.net/browse/TR-652

  • Add useCredentials option to jwtTokenHandler
  • Write tests for new refreshToken method.

Test:

  • npm run test

@btamas btamas marked this pull request as ready for review February 19, 2021 14:04
jsconan
jsconan approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@jsconan jsconan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Checklist

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master

@btamas btamas requested a review from krampstudio February 23, 2021 16:08
meefox
meefox approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@meefox meefox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relied on tests here, all green.
Screenshot 2021-02-22 at 13 57 58

@btamas btamas merged commit c97bb75 into develop Feb 24, 2021
@btamas btamas deleted the feature/TR-652_credential-support-for-jwttokenhandler branch February 24, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meefox meefox meefox approved these changes

@jsconan jsconan jsconan approved these changes

@lecosson lecosson Awaiting requested review from lecosson

@krampstudio krampstudio Awaiting requested review from krampstudio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@btamas @krampstudio @jsconan @meefox