-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add schema type metadata #231
Conversation
@danielfett @bc-pi Do you think it makes sense to describe the base document for schema type metadata validation? For example, a verifier receiving an SD-JWT VC with Disclosures won't be able to validate the JSON schema against it before transforming the entire SD-JWT VC with Disclosures to expanded JSON document first. |
@danielfett @bc-pi Should we restrict schema to specific JSON schema versions? |
Co-authored-by: Daniel Fett <fett@danielfett.de>
I'm honestly not familiar with the intricacies of JSON schema. Is/are there a stable standard version(s) that can be referenced from a prospective RFC? The current content of the PR seems to have some normative statements but no reference. I'd think that's kind of a prerequisite to discussing version restrictions/requirements. A few minutes of looking around and I found this https://json-schema.org/specification-links which at least suggests it's a bit messy. Any idea if/how other actual standards documents utilize JSON schema? |
Well, statements like "MUST validate the Verifiable Credential against the provided JSON Schema document." probably need some more clarity about what part of the VC and at what stage of transformation/processing. |
I suggest that we proceed with merging this PR nonetheless and have a separate discussion on JSON Schema versions in an issue. |
Update: We don't need IANA registration for schema, schema_uri and schema_uri#integrity since type metadata is not a JWT. |
@bc-pi @danielfett Can you please check the examples I added. |
I believe we will need to distinguish between presentation and issuance schemas -> see #237 |
I don't really speak JSON schema but it looks ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a couple of editorial remarks, but generally this looks good to me, thank you!
Co-authored-by: Daniel Fett <fett@danielfett.de>
Co-authored-by: Daniel Fett <fett@danielfett.de>
Co-authored-by: Daniel Fett <fett@danielfett.de>
Co-authored-by: Daniel Fett <fett@danielfett.de>
Thanks a lot. I updated the PR. Will merge later on the editor's call. |
Merging this since all comments were addressed. |
This PR includes the following:
IANA considerations forschema
,schema_uri
andschema_uri#integrity
See preview here:
https://drafts.oauth.net/oauth-sd-jwt-vc/awoie/fix-229-schema/draft-ietf-oauth-sd-jwt-vc.html
Fixes #229