Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add display and claim metadata #236

Merged
merged 23 commits into from
Sep 17, 2024

Conversation

danielfett
Copy link
Member

@danielfett danielfett commented Jun 5, 2024

This PR adds the display and claim metadata as defined in the Type Metadata draft (with minor changes).

Note that this includes the "claim verification metadata" and "claim selective disclosure metadata", where there were some discussions around the requirements and mechanisms to use. I left them in here to foster a discussion, but we can also split them out into separate PRs.

Rendered version: https://drafts.oauth.net/oauth-sd-jwt-vc/danielfett/fix-224-add-display-metadata/draft-ietf-oauth-sd-jwt-vc.html

@danielfett danielfett requested review from awoie and bc-pi as code owners June 5, 2024 10:42
Copy link
Collaborator

@awoie awoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had to remove the display feature language in the schema PR for consistency reasons and because we didn't want to suggest features are included that are in fact not there yet. So, this PR should re-introduce the language in the type metadata intro:

, and how they can be displayed.

@bc-pi
Copy link
Collaborator

bc-pi commented Jul 1, 2024

We had to remove the display feature language in the schema PR for consistency reasons and because we didn't want to suggest features are included that are in fact not there yet. So, this PR should re-introduce the language in the type metadata intro:

, and how they can be displayed.

https://github.com/oauth-wg/oauth-sd-jwt-vc/pull/231/files#r1661453204 and https://github.com/oauth-wg/oauth-sd-jwt-vc/pull/231/files#diff-e750c0958ca10e395b4d3b77bb5aafccc668b4a1a50675dda79a8d90b39a2468L494 are where that happened or will happen

draft-ietf-oauth-sd-jwt-vc.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@bc-pi bc-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the language tag approach to reflect the rough consensus achieved briefly in the room (where you were not present) at IETF 120

@danielfett danielfett requested review from awoie and bc-pi August 15, 2024 08:21
@bc-pi bc-pi self-requested a review August 20, 2024 18:23
Copy link
Collaborator

@bc-pi bc-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes sorry... but the issuer isn't always the owner of the type metadata

draft-ietf-oauth-sd-jwt-vc.md Outdated Show resolved Hide resolved
draft-ietf-oauth-sd-jwt-vc.md Outdated Show resolved Hide resolved
…Type Metadata

Co-authored-by: Daniel Fett <fett@danielfett.de>
draft-ietf-oauth-sd-jwt-vc.md Outdated Show resolved Hide resolved
draft-ietf-oauth-sd-jwt-vc.md Show resolved Hide resolved
draft-ietf-oauth-sd-jwt-vc.md Show resolved Hide resolved
draft-ietf-oauth-sd-jwt-vc.md Outdated Show resolved Hide resolved
draft-ietf-oauth-sd-jwt-vc.md Outdated Show resolved Hide resolved
draft-ietf-oauth-sd-jwt-vc.md Show resolved Hide resolved
draft-ietf-oauth-sd-jwt-vc.md Outdated Show resolved Hide resolved
Co-authored-by: Oliver Terbu <o.terbu@gmail.com>
Copy link
Collaborator

@bc-pi bc-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nit picky suggestions but overall lgtm

draft-ietf-oauth-sd-jwt-vc.md Outdated Show resolved Hide resolved
draft-ietf-oauth-sd-jwt-vc.md Outdated Show resolved Hide resolved
draft-ietf-oauth-sd-jwt-vc.md Outdated Show resolved Hide resolved
draft-ietf-oauth-sd-jwt-vc.md Outdated Show resolved Hide resolved
draft-ietf-oauth-sd-jwt-vc.md Outdated Show resolved Hide resolved
draft-ietf-oauth-sd-jwt-vc.md Outdated Show resolved Hide resolved
draft-ietf-oauth-sd-jwt-vc.md Outdated Show resolved Hide resolved
bc-pi and others added 2 commits September 13, 2024 14:15
Co-authored-by: Brian Campbell <71398439+bc-pi@users.noreply.github.com>
@danielfett danielfett merged commit 7f525e7 into main Sep 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants