Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WGLC updates 2/x (remove sentence in intro) #473

Closed
wants to merge 1 commit into from

Conversation

bc-pi
Copy link
Collaborator

@bc-pi bc-pi commented Oct 4, 2024

remove repetitive repetitive sentence per Dick https://mailarchive.ie)tf.org/arch/msg/oauth/brjnGB53MApGNCsXC03ungeWxI4/

@bc-pi bc-pi mentioned this pull request Oct 4, 2024
Copy link
Member

@danielfett danielfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci!

Copy link
Collaborator

@Sakurann Sakurann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with adding Dick as a contributor, but I am not ok removing this sentence (line 111), sorry. like, this is the only sentence that is left from when we used to say "sd-jwt can be used with json-ld", and "The JSON-based representation of claims in a signed JWT..." in the intro is not as clear as the sentence being deleted.

@bc-pi
Copy link
Collaborator Author

bc-pi commented Oct 9, 2024

I am ok with adding Dick as a contributor, but I am not ok removing this sentence (line 111), sorry. like, this is the only sentence that is left from when we used to say "sd-jwt can be used with json-ld", and "The JSON-based representation of claims in a signed JWT..." in the intro is not as clear as the sentence being deleted.

Okay, let's just close this one then. I was just trying to incorporate some of the various WGLC feedback and this seemed reasonable. Keeping it seems reasonable as well. COMPLETELY REASONABLE even.

@bc-pi bc-pi changed the title WGLC updates 2/x WGLC updates 2/x (remove sentence in intro) Oct 9, 2024
@bc-pi
Copy link
Collaborator Author

bc-pi commented Oct 9, 2024

@danielfett is going to rework the introduction too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants