Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seconds vs. milliseconds in the example #114

Closed
dteleguin opened this issue Jul 22, 2024 · 1 comment
Closed

Seconds vs. milliseconds in the example #114

dteleguin opened this issue Jul 22, 2024 · 1 comment

Comments

@dteleguin
Copy link

In 5.2.4:

{
  "iat": "1686536226000",
  "aud": "trust-domain.example",
  "exp": "1686536526000",
  ...
}

The iat and exp claims are strings expressed in milliseconds. According to RFC 7519 4.1, those should be numerics and expressed in seconds.

@gffletch
Copy link
Collaborator

Thank you! Will update the examples to be correct.

gffletch added a commit to gffletch/transaction-tokens that referenced this issue Jul 24, 2024
Correcting the JSON example to use NumericDate for `iat` and `exp` claims.
tulshi added a commit that referenced this issue Jul 24, 2024
Correct JSON example - address issue #114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants