Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 0.5.5 regression #186

Merged
merged 3 commits into from
Oct 31, 2021
Merged

Conversation

morganick
Copy link

When reviewing the changes between 0.5.4 -> 0.5.5, I noticed that the error handling had been shifted later in the method unnecessarily.

This commit reverts the ordering that was changed in:
d74b767#diff-7539411a25dc370ad4ed8baed9d33ad853f07cadcfcc8c566494ecc438f5bd16

Once we know we are in an infinite redirect, we should fail immediately. This keeps us from creating an unnecessary HTTP object and any side-effects from creating one. (e.g. additional allocations, URI parsing errors, etc.)

I've run the specs against ruby 2.7.3 with 0 failures.

Note: I rarely use Minitest so feedback welcome.

Nick Morgan and others added 3 commits April 25, 2021 19:26
@pboling pboling merged commit 4584e36 into oauth-xx:master Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants