Allow configuring terminationGracePeriodSeconds and lifecycle hooks #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@karel1980 Thank you for your contribution. The PR needs a bump of the Chart version and an annotation for aAtifactHub to be approved. |
|
Will do. Thanks for the quick feedback. |
|
@pierluigilenoci I've made the requested changes. I'm not familiar with artifacthub.io, I'm guessing the fix from the 6.19.1 release needed to be removed. If not, let me know I'll add it back in a jiffy |
pierluigilenoci
previously approved these changes
Nov 28, 2023
pierluigilenoci
approved these changes
Nov 28, 2023
|
@karel1980 Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please accept my humble PR.
These changes would help with zero downtime deployments on EKS.
For sources, please see these issues:
kubernetes-sigs/aws-load-balancer-controller#2366
kubernetes-sigs/aws-load-balancer-controller#1064