Added ADFS Provider #1238
Merged
Added ADFS Provider #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samirachoadi
force-pushed
the
feature/add_adfs_provider
branch
from
b574ae4
to
cc83db3
Compare
|
Sorry @NickMeves I think I messed up the old pull request with the rebase. I just opened a new one. |
samirachoadi
force-pushed
the
feature/add_adfs_provider
branch
from
cc83db3
to
a14c0c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added ADFS provider to support Windows Server openid Web Sign On.
Motivation and Context
We're planning to use aotuh2-proxy as one of the authentication systems for webapps for the company I'm working on. In order to achieve this goal, It will be very helpful to support ADFS since it's currently in use for many projects.
How Has This Been Tested?
Wrote unit tests with the ginko library taking as examples gitlab_test.go and keycloak_test.go
Created an ADFS openid application and configured a dev environment pointing to the company test ADFS openid endpoint.
Tested regular user login with web-browser with SSO enabled and disabled.
Tested login with Authentication Bearer header and a programmatically generated token.
Created a new provider called adfs.
Created tests.
Added the new provider to the providers list.
Added documentation.
Since it's a different provider it shouldn't affect any other parts of the code or break compatibility.
Checklist: