Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go-oidc to v3 #1264

Merged
merged 2 commits into from
Jul 17, 2021
Merged

Upgrade go-oidc to v3 #1264

merged 2 commits into from
Jul 17, 2021

Conversation

NickMeves
Copy link
Contributor

@NickMeves NickMeves commented Jul 4, 2021

Description

Update to go-oidc/v3 which handles JWKS key rotations better & inline with the OIDC spec.

Motivation and Context

Keeping dependencies current & potential fix for:
#1260

How Has This Been Tested?

Unit Tests
@natefear Can you test this branch in your environment and confirm it fixes the rotation bug you raised?

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

@NickMeves NickMeves requested a review from a team as a code owner July 4, 2021 16:30
@NickMeves NickMeves linked an issue Jul 4, 2021 that may be closed by this pull request
Copy link
Member

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll let you merge this when you're ready

@NickMeves NickMeves merged commit 0b4bc36 into master Jul 17, 2021
@NickMeves NickMeves deleted the update-go-oidc branch July 17, 2021 16:55
goshlanguage pushed a commit to goshlanguage/oauth2-proxy that referenced this pull request Sep 20, 2021
k-jell pushed a commit to liquidinvestigations/oauth2-proxy that referenced this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JWT validation fails after EKS OIDC provider's key rotation
2 participants