Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add description on ipv6 address #1635

Merged
merged 7 commits into from
May 23, 2022
Merged

Add description on ipv6 address #1635

merged 7 commits into from
May 23, 2022

Conversation

t-katsumura
Copy link
Contributor

@t-katsumura t-katsumura commented Apr 29, 2022 •
edited
Loading

Description

Added description on how to configure ipv6 address to listen to
Added unit tests for ipv6 adress

Motivation and Context

#1537

How Has This Been Tested?

Unit tests which I added
Also tested with manually on my local environment if ipv6 adress works

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

@t-katsumura t-katsumura requested a review from a team as a code owner April 29, 2022 14:27
@t-katsumura t-katsumura changed the title Add description on ipv6 address #1537 Add description on ipv6 address Apr 29, 2022
JoelSpeed
JoelSpeed reviewed May 20, 2022
View reviewed changes
Copy link
Member

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, looks great! Could you please add a changelog entry and I'll get this merged

@t-katsumura
Copy link
Contributor Author

@JoelSpeed
Thank you for your checking!
I added changelog entry

JoelSpeed
JoelSpeed approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@JoelSpeed JoelSpeed merged commit c6a9836 into oauth2-proxy:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-katsumura @JoelSpeed