Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move root packages to pkg folder #187

Merged
merged 6 commits into from
Jul 15, 2019
Merged

Move root packages to pkg folder #187

merged 6 commits into from
Jul 15, 2019

Conversation

JoelSpeed
Copy link
Member

Description

This moves the api, cookie and logger packages at the top level of the repository to the pkg folder.

Motivation and Context

Refactor towards a tidier repository, eventually all packages should be under pkg to be more idiomatic.

How Has This Been Tested?

It's just a refactor, no logical changes.

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

@JoelSpeed JoelSpeed requested review from loshz and a team June 15, 2019 09:26
steakunderscore
steakunderscore approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member

@steakunderscore steakunderscore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

loshz
loshz previously approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member

@loshz loshz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

steakunderscore
steakunderscore previously approved these changes Jul 13, 2019
View reviewed changes
Copy link
Member

@steakunderscore steakunderscore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoelSpeed JoelSpeed dismissed stale reviews from steakunderscore and loshz via 630db37 July 15, 2019 10:30
@JoelSpeed JoelSpeed merged commit 6311fa2 into master Jul 15, 2019
@JoelSpeed JoelSpeed deleted the refactor branch July 15, 2019 10:43
@weltonrodrigo weltonrodrigo mentioned this pull request Feb 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonderhoss wonderhoss wonderhoss approved these changes

@steakunderscore steakunderscore steakunderscore left review comments

@loshz loshz loshz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JoelSpeed @steakunderscore @loshz @wonderhoss