Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed name for GoogleGroups env variable + unit tests #2221

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Fixed name for GoogleGroups env variable + unit tests #2221

merged 3 commits into from
Sep 8, 2023

Conversation

kvanzuijlen
Copy link
Member

@kvanzuijlen kvanzuijlen commented Sep 5, 2023 •
edited

Description

Fixes the name of the GoogleGroups env variable (from OAUTH2_PROXY_GOOGLE_GROUP to OAUTH2_PROXY_GOOGLE_GROUPS)

Motivation and Context

Closes #2201

How Has This Been Tested?

Ran the application using the debugger with all 3 settings (--google-group, OAUTH2_PROXY_GOOGLE_GROUP, and OAUTH2_PROXY_GOOGLE_GROUPS), as well as added tests to proof reading the old env variable still results in the same outcome

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

@kvanzuijlen kvanzuijlen requested a review from a team as a code owner September 5, 2023 23:28
JoelSpeed
JoelSpeed previously approved these changes Sep 8, 2023
View reviewed changes
@JoelSpeed JoelSpeed added the bug label Sep 8, 2023
@JoelSpeed JoelSpeed merged commit f3269b3 into oauth2-proxy:master Sep 8, 2023
5 checks passed
@tuunit tuunit added this to the v7.5.1 milestone Sep 13, 2023
@ZhongRuoyu ZhongRuoyu mentioned this pull request Sep 22, 2023
Merged
flobeier pushed a commit to flobeier/oauth2-proxy that referenced this pull request Oct 18, 2023
@kvanzuijlen @JoelSpeed @flobeier
Fixed name for GoogleGroups env variable + unit tests (oauth2-proxy#2221
73c92a5 
)

* Fixed name for GoogleGroups env variable + unit tests

* Added changelog

---------

Co-authored-by: Joel Speed <Joel.speed@hotmail.co.uk>
isodude pushed a commit to isodude/oauth2-proxy that referenced this pull request Nov 7, 2023
@kvanzuijlen @JoelSpeed @isodude
Fixed name for GoogleGroups env variable + unit tests (oauth2-proxy#2221
8c034bc 
)

* Fixed name for GoogleGroups env variable + unit tests

* Added changelog

---------

Co-authored-by: Joel Speed <Joel.speed@hotmail.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v7.5.1
Development

Successfully merging this pull request may close these issues.

google-group argument is mapped to OAUTH2_PROXY_GOOGLE_GROUP (no trailing S)
3 participants
@kvanzuijlen @JoelSpeed @tuunit