Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade golang.org/x/net to v0.17.0 #2274

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Upgrade golang.org/x/net to v0.17.0 #2274

merged 3 commits into from
Oct 24, 2023

Conversation

pierluigilenoci
Copy link
Contributor

@pierluigilenoci pierluigilenoci commented Oct 18, 2023 •
edited

https://artifacthub.io/packages/helm/oauth2-proxy/oauth2-proxy?modal=security-report

Description

Motivation and Context

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

@pierluigilenoci pierluigilenoci requested a review from a team as a code owner October 18, 2023 09:42
JoelSpeed
JoelSpeed previously approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this one, LGTM

@JoelSpeed JoelSpeed added bug dependencies Pull requests that update a dependency file labels Oct 18, 2023
@tuunit
Copy link
Member

tuunit commented Oct 18, 2023 •
edited

Hi @pierluigilenoci,

please run go mod tidy on your branch and commit the changes to the go.mod and go.sum files as well. When updating go dependencies best to use go get golang.org/x/net@vX.X.X to update the full dependency graph or update the version in go.mod by hand and run go mod tidy afterwards.

@pierluigilenoci
Copy link
Contributor Author

@JoelSpeed @tuunit could you please take a look?

@JoelSpeed JoelSpeed merged commit 8d03adf into oauth2-proxy:master Oct 24, 2023
5 checks passed
@pierluigilenoci pierluigilenoci deleted the patch-1 branch November 6, 2023 15:16
@BrewTestBot BrewTestBot mentioned this pull request Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvanzuijlen kvanzuijlen kvanzuijlen approved these changes

@JoelSpeed JoelSpeed JoelSpeed approved these changes

Assignees
No one assigned
Labels
bug dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pierluigilenoci @tuunit @kvanzuijlen @JoelSpeed