Fixed Google ADC functionality #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md # go.mod # go.sum
JoelSpeed
reviewed
Oct 24, 2023
JoelSpeed
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2260. Apparantly, Workload Identity can't directly call the Directory API, instead, Workload Identity should first impersonate the Service Account itself and then call the Directory API
Motivation and Context
Currently, checking Google groups through Workload Identity on GKE, doesn't work. This fixes that issue.
How Has This Been Tested?
Ran it both locally and on a real GKE cluster. Made use of https://github.com/salrashid123/gce_metadata_server locally to simulate a GCP environment as much as possible. Both local and GKE cluster work.
Checklist: