Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keycloak: Add Token Refresh #2601

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Primexz
Copy link

@Primexz Primexz commented Apr 8, 2024

Description

The missing implementation of the token refresh for the OAuth2 provider: "Keycloak" is implemented here.

Motivation and Context

When using the OAuth2 proxy, I noticed that no token refresh is implemented for the provider: "Keycloak". In the past, this issue has already been noted in issue: #501.
This PR will fix #501.

How Has This Been Tested?

I have tested whether the session is updated in the browser and a new cookie is written.

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.
  • I have written tests for my code changes.

@Primexz Primexz requested a review from a team as a code owner April 8, 2024 14:40
@Primexz Primexz changed the title feat(keycloak): add token refresh Keycloak: Add Token Refresh Apr 8, 2024
@github-actions github-actions bot added the docs label Apr 8, 2024
Copy link
Member

@tuunit tuunit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should continue with this PR. This is the legacy Keycloak provider which is more or less deprecated and shouldn't be used anymore. Please use the Keycloak OIDC provider. Any reason you are using the legacy provider?

image

@farfalleflickan
Copy link

Ran into this while using "Keycloak OIDC", had 502 errors until I disabled "Use refresh tokens" in keycloak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With the “keycloak” provider cookie-refresh does not work
3 participants