Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unable to use hyphen in JSON path for oidc-groups-claim option #2619

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rd-danny-fleer
Copy link

@rd-danny-fleer rd-danny-fleer commented Apr 26, 2024

Description

  • Removed dependency "github.com/ohler55/ojg/jp"
  • Always evaluate claim as string literal first and as JSON path as fallback

Motivation and Context

Fix #2618

I know there might be better solutions, like implementing a feature flag and an additional option to control if oidc-groups-claims should be evaluated as string or JSON path.
However such a change might be breaking and I didn't want to anticipate the decision for an alternative. Therefore I implemented a simple solution in the first step.

How Has This Been Tested?

Added additional tests.

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.
  • I have written tests for my code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to use hyphen in JSON path for oidc-groups-claim option
1 participant