Disable cgo on release builds #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tries to link against libc which isn't present in musl based distributions (such as Alpine Linux). Closes oauth2-proxy#329
tomelliff
requested review from
JoelSpeed,
steakunderscore and
loshz
as code owners
|
I don't think this needs a changelog entry because it's just fixing the build process and isn't user facing really but let me know if you want me to add something anyway. |
JoelSpeed
reviewed
Jan 28, 2020
There was a problem hiding this comment.
Thanks @tomeliff for playing about with this and verifying this fixes the issue. I was pretty sure we had had the CGO_ENABLED=0 option before but as you say, it got lost!
As people have had issues running this on alpine with the latest release, I would suggest this is a bug fix and that a changelog entry should be added
@syscll, since you've modified these files recently, can you see any issue adding this back?
loshz
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cgo tries to link against libc which isn't present in musl based distributions (such as Alpine Linux).
Motivation and Context
#329
How Has This Been Tested?
make releasereadelf -l release/oauth2_proxy-v4.1.0-37-gd9362d3-dirty.linux-amd64.go1.13.1/oauth2_proxy | grep "program interpreter"docker run -it --rm -v $PWD:/work -w /work alpine ./release/oauth2_proxy-v4.1.0-37-gd9362d3-dirty.linux-amd64.go1.13.1/oauth2_proxy --helpI don't have a non Linux machine to test this on but I don't see why this would be broken on any other arch/os. The v4.0.0 release used to disable cgo until the
dist.shrewrite in #302 which I think inadvertently reintroduced it.Checklist: