Improve Redirect to HTTPs behaviour #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelSpeed
force-pushed
the
https-redirect-middleware
branch
2 times, most recently
from
a599389
to
c3843fc
Compare
JoelSpeed
force-pushed
the
https-redirect-middleware
branch
2 times, most recently
from
f06e065
to
498975c
Compare
|
@jmickey Not sure if you're still interested in this project or not, but since you originally authored the redirect to https behaviour, might be good to get your opinion on this change |
|
👋 I would be happy to take a look! I should be able to do that later this arvo. |
jmickey
previously approved these changes
Jul 3, 2020
|
LGTM. Solid solution and good tests. Agree that it's also more useful! |
Moves the logic for redirecting to HTTPs to a middleware package and adds tests for this logic. Also makes the functionality more useful, previously it always redirected to the HTTPS address of the proxy, which may not have been intended, now it will redirect based on if a port is provided in the URL (assume public facing 80 to 443 or 4180 to 8443 for example)
JoelSpeed
force-pushed
the
https-redirect-middleware
branch
from
498975c
to
1c11067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the logic for redirecting to HTTPs to a middleware package and adds tests for this logic.
Also makes the functionality more useful, previously it always redirected to the HTTPS address of the proxy, which may not have been intended, now it will redirect based on if a port is provided in the URL (assume public facing 80 to 443 or 4180 to 8443 for example)
Motivation and Context
Trying to break logic down into smaller logic chunks. First in a step to migrating a few areas of the code to small middlewares.
How Has This Been Tested?
Unit testing.
Checklist: