Support TLS 1.3 #923
Merged
Support TLS 1.3 #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I saw #833 after opening the PR. |
|
Please add a note to the changelog mentioning this change and I'm happy to get this merged |
|
Thank you @JoelSpeed for your review. Added a note to the changelog. BTW, I found an existing typo |
Go for it - Thanks! |
|
Thank you @JoelSpeed and @NickMeves ! |
k-jell
pushed a commit
to liquidinvestigations/oauth2-proxy
that referenced
this pull request
Apr 6, 2022
* Support TLS 1.3 * Set TLS 1.3 explicitly to fix gosec warning. * Add an entry to changelog. * Fix typo in the changelog. Co-authored-by: Joel Speed <Joel.speed@hotmail.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set "tls.MaxVersion = tls.VersionTLS13" to use TLS 1.3 if possible.
Motivation and Context
Now the TLS version is hard-coded and it does not support TLS 1.3.
How Has This Been Tested?
Manually tested. I compiled and deployed in CentOS 7 and ran curl command.
Checklist: