Skip to content
This repository has been archived by the owner on Mar 10, 2021. It is now read-only.

Refactor #21

Merged
merged 8 commits into from
Nov 25, 2019
Merged

Refactor #21

merged 8 commits into from
Nov 25, 2019

Conversation

obalunenko
Copy link
Owner

No description provided.

internal/models/model.go Show resolved Hide resolved
internal/db/storage.go Show resolved Hide resolved
internal/config/config_test.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Nov 24, 2019

Pull Request Test Coverage Report for Build 165

  • 30 of 151 (19.87%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.2%) to 40.599%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/converter/converter.go 13 17 76.47%
cmd/logs-converter-cli/version.go 0 5 0.0%
internal/db/storage.go 0 9 0.0%
internal/db/storagetype_string.go 0 13 0.0%
cmd/logs-converter-cli/main.go 0 35 0.0%
internal/db/mongo.go 0 55 0.0%
Totals Coverage Status
Change from base Build 151: -3.2%
Covered Lines: 149
Relevant Lines: 367

💛 - Coveralls

@codecov
Copy link

codecov bot commented Nov 24, 2019

Codecov Report

Merging #21 into master will decrease coverage by 3%.
The diff coverage is 20.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   41.79%   38.79%   -3.01%     
==========================================
  Files           5        7       +2     
  Lines         268      281      +13     
==========================================
- Hits          112      109       -3     
- Misses        150      167      +17     
+ Partials        6        5       -1
Impacted Files Coverage Δ
cmd/logs-converter-cli/main.go 0% <0%> (ø)
internal/db/mongo.go 0% <0%> (ø)
internal/db/storage.go 0% <0%> (ø)
cmd/logs-converter-cli/version.go 0% <0%> (ø)
internal/db/storagetype_string.go 0% <0%> (ø)
internal/config/config.go 85.71% <86.66%> (ø)
internal/converter/converter.go 59.61% <92.85%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9c53ca...eb1effb. Read the comment docs.

internal/db/mongo/db.go Outdated Show resolved Hide resolved
internal/db/mongo/db.go Outdated Show resolved Hide resolved
}

// Connect establish connection to passed database type
func Connect(dbType StorageType, params Params) (Repository, error) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dbType can be fmt.Stringer (from interfacer)

@obalunenko obalunenko merged commit fba0c91 into master Nov 25, 2019
@obalunenko obalunenko deleted the dev branch November 25, 2019 09:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants