Split everything left out of the README #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatyouhide
commented
Nov 12, 2024
sorenone
reviewed
Nov 12, 2024
lib/oban/worker.ex
Outdated
Comment on lines
304
to
320
| ### Caveats & Guidelines | ||
|
|
||
| Usually, scheduled job management operates in `global` mode and notifies queues | ||
| of available jobs via PubSub to minimize database load. However, when PubSub | ||
| isn't available, staging switches to a `local` mode where each queue polls | ||
| independently. | ||
|
|
||
| Local mode is less efficient and will only happen if you're running in an | ||
| environment where neither `Postgres` nor `PG` notifications work. That situation | ||
| should be rare and limited to the following conditions: | ||
|
|
||
| 1. Running with a connection pooler, like [`pg_bouncer`][pg_bouncer], | ||
| in transaction mode. | ||
| 2. Running without clustering, that is, without *distributed Erlang*. | ||
|
|
||
| If **both** of those criteria apply and PubSub notifications won't work, then | ||
| staging will switch to polling in `local` mode. |
There was a problem hiding this comment.
Do you think there a better location for this section? Maybe a guide about distribution/pubsub/notifiers? You're in the head-space for it more than we are right now.
There was a problem hiding this comment.
Yes, we can split this out. The nice thing about splitting it out is that we'll have a home for this stuff (and a URL for it too).
Co-authored-by: Shannon Selbert <shannon@sorentwo.com>
Co-authored-by: Shannon Selbert <shannon@sorentwo.com>
Co-authored-by: Shannon Selbert <shannon@sorentwo.com>
Co-authored-by: Shannon Selbert <shannon@sorentwo.com>
Co-authored-by: Shannon Selbert <shannon@sorentwo.com>
Co-authored-by: Shannon Selbert <shannon@sorentwo.com>
Co-authored-by: Shannon Selbert <shannon@sorentwo.com>
Co-authored-by: Shannon Selbert <shannon@sorentwo.com>
Co-authored-by: Shannon Selbert <shannon@sorentwo.com>
Co-authored-by: Shannon Selbert <shannon@sorentwo.com>
Co-authored-by: Shannon Selbert <shannon@sorentwo.com>
whatyouhide
force-pushed
the
al/final-readme-split
branch
from
fc2890a
to
09f7585
Compare
|
@sorentwo second pass done ✅ |
sorenone
reviewed
Nov 12, 2024
sorenone
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oooph, this is the final one! I’m pretty happy with this one, excited to hear your thoughts.