Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify README.md template: not working with helm mono repository #69

Closed
1 task
obervinov opened this issue Apr 15, 2024 · 0 comments · Fixed by #71
Closed
1 task

Verify README.md template: not working with helm mono repository #69

obervinov opened this issue Apr 15, 2024 · 0 comments · Fixed by #71
Assignees
Labels
bug Something isn't working
Milestone

Comments

@obervinov
Copy link
Owner

obervinov commented Apr 15, 2024

Describe the bug
Verify README.md template:
not working with helm mono repository

To Reproduce
Steps to reproduce the behavior:
https://github.com/obervinov/helm-charts/actions/runs/8694876452/job/23844704726

---
name: Checks and Build Helm-Charts Bundle

# yamllint disable-line rule:truthy
on:
  push:
    branches:
      - '*'
      - '*/*'
      - '**'
      - '!main'

jobs:
  helm-repository-build:
    uses: obervinov/_templates/.github/workflows/helm.yaml@v1.0.12

  changelog:
    uses: obervinov/_templates/.github/workflows/changelog.yaml@v1.1.0
  
  readme:
    uses: obervinov/_templates/.github/workflows/readme.yaml@v1.1.0
---
name: Create GitHub Release

# yamllint disable-line rule:truthy
on:
  pull_request:
    branches:
      - main
    types:
      - closed

jobs:
  helm-repository-build:
    uses: obervinov/_templates/.github/workflows/helm.yaml@v1.0.12

  changelog:
    uses: obervinov/_templates/.github/workflows/changelog.yaml@v1.1.0
  
  readme:
    uses: obervinov/_templates/.github/workflows/readme.yaml@v1.1.0

  create-release:
    uses: obervinov/_templates/.github/workflows/release.yaml@v1.1.0
    needs: [helm-repository-build, changelog, readme]

Expected behavior
workflow for testing https://github.com/obervinov/helm-charts/tree/main/.github/workflows
fix the line: https://github.com/obervinov/_templates/blob/main/.github/workflows/readme.yaml#L25
correct version:

% grep -oE '@(release/|fix/|hotfix/)?v[0-9]+\.[0-9]+\.[0-9]+' .github/workflows/release.yaml  
@v1.1.0
@v1.1.0
@v1.1.0

Screenshots
Снимок экрана 2024-04-15 в 23 28 32

Additional context
None

Check list

  • Verify that the fix works
@obervinov obervinov added the bug Something isn't working label Apr 15, 2024
@obervinov obervinov self-assigned this Apr 15, 2024
@obervinov obervinov added this to the Release/v1.2.0 milestone Apr 16, 2024
obervinov pushed a commit that referenced this issue Apr 16, 2024
obervinov pushed a commit that referenced this issue Apr 28, 2024
#71)

## v1.2.0 - 2024-04-28
### What's Changed
**Full Changelog**: v1.1.1...v1.2.0 by @obervinov in #71
#### 🚀 Features
* #55
* #56
#### 📚 Documentation
* Updated all issue and pull request templates
#### 🐛 Bug Fixes
* #69
* #68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

1 participant