Fix build issue for arm macs #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why QT fails to build for mac have not changed CI. |
|
The problem with |
|
Yes unfortunately extern "C" seems to be the only abi compatible with arm64 
aapcs seems to be 32-bit arm only |
|
Strange. Why |
|
I believe it might be 32-bit only, there is an experimental ABI in the works though for 64-bit ARM I believe rust-lang/rust#65815 |
|
There should be an aapcs64 available but I haven't found the ABI. |
|
Seems like our only solution is fixing this on the call sites. |
ultimaweapon
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes building on arm macs by switching to the
extern "C"abi and fixing an erroneous macro input for the error macro. Closes #260