Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBI asserts a GO:molecular function to be a subclass of GO:biological process #963

Closed
balhoff opened this issue Sep 6, 2018 · 6 comments
Assignees

Comments

@balhoff
Copy link

balhoff commented Sep 6, 2018

(sorry this was submitted prematurely)

OBI contains these axioms:

However in GO sequence-specific DNA binding is an indirect subclass of molecular_function. molecular_function and biological_process are disjoint. So this creates problems using OBI with GO.

I think it is the same situation with core promoter binding.

@bpeters42
Copy link
Contributor

We would appreciate help from the GO community how to do this better. Hopefully @cmungall can chime in. The basic problem has been that OBI originally took the view that GO:'molecular function was a kind of BFO:function. But we were then made aware that GO treats molecular function as a type of BFO:process. It has not been clear to us what constitutes the difference between GO:molecular function vs. GO:biological process. OBI:binding was created when the only BFO:process in GO we were aware of was GO:'biological process'. And we wanted to describe the processes that occur during an assay that are being measured. It seems we can now refer to those as 'biological process or molecular function'.

OBI:binding was created as a placeholder that we would be happy to replace. There are editor notes in that regard on the term. And we we should now explore replacing OBI:binding with GO:binding (GO_0005488), which seems to work for all current children of OBI:binding.

However, originally we intended for OBI:binding to cover other binding processes, such as cell:cell interactions, which I suspect GO would put under 'biological process'. Minimally the label 'binding' seems very general for GO if it only applies to 'molecular function', however that is defined.

@balhoff
Copy link
Author

balhoff commented Sep 10, 2018

@bpeters42 I agree the distinction between GO:molecular function and GO:biological process is unclear. We discussed this on the GO editors call today. GO does take the view that molecular functions are parts of biological process. Perhaps the solution for OBI would be to simply use BFO:process to group these terms instead of the GO:biological process. Or, perhaps the union you suggested. Regarding 'binding', I agree it is a pretty broad label; the GO definition is very specific.

@cmungall or @ukemi please add if I've left something out.

@cmungall
Copy link
Contributor

Good summary

Perhaps GO should relabel it's binding to 'molecular binding' or somesuch - or at least have an obofoundry unique label property on it

@bpeters42
Copy link
Contributor

bpeters42 commented Sep 12, 2018 via email

@cmungall
Copy link
Contributor

That's correct. I think we can even go one step further and assume all siblings are disjoint here (but not exhaustive)

@jamesaoverton jamesaoverton self-assigned this Sep 24, 2018
@jamesaoverton
Copy link
Contributor

jamesaoverton commented Mar 11, 2019

I believe that this was addressed in #936 and the change has been released. Please reopen if I'm mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants