Skip to content

Commit

Permalink
Update cache keys in test-inputs.yml (#79)
Browse files Browse the repository at this point in the history
It's always caching. Or DNS. This time it was caching.

A while back, we changed the default cache key prefix from empty-string to `semver` so that our cache key names don't start with a dash, since users found that confusing.

We should have updated these tests accordingly at the time, but we did not. So how did the PR with the change pass?

It used the caches from older runs of the same job which used the old names. When those caches expired and were GC'd by GitHub, the jobs started failing.

This is what broke CI for #77. This PR will fix it.
  • Loading branch information
obi1kenobi authored Jul 2, 2024
1 parent c730648 commit 300d7d4
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/test-inputs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -286,9 +286,9 @@ jobs:
path: ${{ github.workspace }}/semver-checks/target/semver-checks/cache
fail-on-cache-miss: true
lookup-only: true
key: -${{ github.job }}
key: semver-${{ github.job }}
restore-keys: |
-${{ github.job }}
semver-${{ github.job }}
- name: Fail if the toolchain used by the action is invalid
if: ${{ ! contains(steps.get-cache-key.outputs.cache-matched-key, 'nightly') }}
run: |
Expand Down Expand Up @@ -329,9 +329,9 @@ jobs:
path: ${{ github.workspace }}/semver-checks/target/semver-checks/cache
fail-on-cache-miss: true
lookup-only: true
key: -${{ github.job }}
key: semver-${{ github.job }}
restore-keys: |
-${{ github.job }}
semver-${{ github.job }}
- name: Fail if the toolchain used by the action is invalid
if: ${{ ! contains(steps.get-cache-key.outputs.cache-matched-key, 'nightly') }}
run: |
Expand Down Expand Up @@ -372,9 +372,9 @@ jobs:
path: ${{ github.workspace }}/semver-checks/target/semver-checks/cache
fail-on-cache-miss: true
lookup-only: true
key: -${{ github.job }}
key: semver-${{ github.job }}
restore-keys: |
-${{ github.job }}
semver-${{ github.job }}
- name: Fail if the toolchain used by the action is invalid
if: ${{ ! contains(steps.get-cache-key.outputs.cache-matched-key, 'beta') }}
run: |
Expand Down

0 comments on commit 300d7d4

Please sign in to comment.