Add lint for missing pub module-level const #491
Conversation
There was a problem hiding this comment.
This looks headed in a good direction, good job so far!
I think usual Rust style is to use ALL_CAPS for const and static items, and I think clippy will complain about the naming in the test crates. Would you mind double-checking this and then if needed uppercasing the const and static names in the test crates?
There was a problem hiding this comment.
I'm going to look into the re-export issue you're seeing, it's possible the bug is in my code.
So we can parallelize work, could you try in the meantime to find a good reference link for why this is a major breaking change, and also work on the remaining TODOs in the description and user-facing error text? Aim for correct but concise text in all those — we really want them as short as feasible while conveying all the important info.
This addresses part of #366