Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optimization to VertexType entrypoint in schema adapter #339

Merged
merged 13 commits into from
Jul 12, 2023
Merged

Add optimization to VertexType entrypoint in schema adapter #339

merged 13 commits into from
Jul 12, 2023

Conversation

u9g
Copy link
Contributor

@u9g u9g commented Jul 3, 2023

No description provided.

@u9g u9g changed the title it works! Add optimization to VertexType entrypoint in schema adapter Jul 3, 2023
obi1kenobi
obi1kenobi reviewed Jul 3, 2023
View reviewed changes
Copy link
Owner

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit, otherwise lgtm! 🚀

trustfall_core/src/schema/adapter/mod.rs Outdated Show resolved Hide resolved
obi1kenobi
obi1kenobi reviewed Jul 3, 2023
View reviewed changes
Copy link
Owner

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other idea here!

trustfall_core/src/schema/adapter/mod.rs Outdated Show resolved Hide resolved
@u9g u9g mentioned this pull request Jul 7, 2023
Open
obi1kenobi
obi1kenobi reviewed Jul 12, 2023
View reviewed changes
Copy link
Owner

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor nitpicks, should be good to go after these tweaks.

trustfall_core/src/schema/adapter/mod.rs Outdated Show resolved Hide resolved
trustfall_core/src/schema/adapter/mod.rs Outdated Show resolved Hide resolved
trustfall_core/src/schema/adapter/tests.rs Outdated Show resolved Hide resolved
u9g and others added 4 commits July 12, 2023 16:07
@obi1kenobi obi1kenobi merged commit 2e2c7c9 into obi1kenobi:main Jul 12, 2023
@u9g u9g deleted the schema-adapter-gets-resolved branch July 12, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obi1kenobi obi1kenobi obi1kenobi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@u9g @obi1kenobi