Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow new Safari and iOS in the playground. #524

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Allow new Safari and iOS in the playground. #524

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db61590
Allow new Safari and iOS in the playground.
obi1kenobi Dec 6, 2023
ca4d1bb
Merge branch 'main' into allow_new_ios_and_safari_in_playground
obi1kenobi Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
115 changes: 67 additions & 48 deletions experiments/browser_based_querying/src/hackernews/Playground.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,55 +235,74 @@ export default function HackerNewsPlayground(): JSX.Element {
};
}, [fetcherWorker, queryWorker, handleQueryMessage, handleQueryError]);

if (BROWSER && BROWSER.name === 'safari') {
return (
<PlaygroundNonIdealState>
<Box>
<WebAssetOff sx={{ fontSize: '100px', mb: 2 }} />
<Typography variant="h5">Safari and iOS browsers not supported</Typography>
<Typography variant="body1">
<p>
Due to an{' '}
<Link
href="https://bugs.webkit.org/show_bug.cgi?id=238442"
target="_blank"
rel="noreferrer"
>
open issue
</Link>{' '}
in the WebKit engine, this demo does not work in Safari.
</p>
<p>Please use a supported browser, such as Firefox or Chrome.</p>
</Typography>
</Box>
</PlaygroundNonIdealState>
);
}
const ios = BROWSER && BROWSER.os === 'iOS';
const oldSafari = BROWSER && BROWSER.name == 'safari' && (BROWSER.version === null || BROWSER.version < "16.6");

if (BROWSER && BROWSER.os === 'iOS') {
return (
<PlaygroundNonIdealState>
<Box>
<WebAssetOff sx={{ fontSize: '100px', mb: 2 }} />
<Typography variant="h5">iOS not supported</Typography>
<Typography variant="body1">
<p>
Due to an{' '}
<Link
href="https://bugs.webkit.org/show_bug.cgi?id=238442"
target="_blank"
rel="noreferrer"
>
open issue
</Link>{' '}
in the WebKit engine, this demo does not work on iOS-based mobile devices or in the
Safari desktop browser.
</p>
<p>Please try this demo on desktop (in Firefox or Chrome) or on an Android device.</p>
</Typography>
</Box>
</PlaygroundNonIdealState>
);
if (oldSafari) {
const browserVersion = BROWSER.version || '';
if (ios && oldSafari) {
return (
<PlaygroundNonIdealState>
<Box>
<WebAssetOff sx={{ fontSize: '100px', mb: 2 }} />
<Typography variant="h5">Please update your iOS version</Typography>
<Typography variant="body1">
<p>
Due to an{' '}
<Link
href="https://bugs.webkit.org/show_bug.cgi?id=238442"
target="_blank"
rel="noreferrer"
>
open issue
</Link>{' '}
in the WebKit engine, this page requires Safari 16.6 or newer, which shipped with iOS 16.7.
</p>
<p>Please update to a newer version of iOS and Safari, or visit this page on another device.</p>
<p>
We believe you are currently using Safari {browserVersion} on iOS.
If this is incorrect, please{' '}<Link
href="https://github.com/obi1kenobi/trustfall/issues/new"
target="_blank"
rel="noreferrer"
>let us know</Link>.
</p>
</Typography>
</Box>
</PlaygroundNonIdealState>
);
} else {
return (
<PlaygroundNonIdealState>
<Box>
<WebAssetOff sx={{ fontSize: '100px', mb: 2 }} />
<Typography variant="h5">Please update your browser version</Typography>
<Typography variant="body1">
<p>
Due to a{' '}
<Link
href="https://bugs.webkit.org/show_bug.cgi?id=238442"
target="_blank"
rel="noreferrer"
>
bug
</Link>{' '}
in the WebKit engine, this page requires Safari 16.6 or newer.
</p>
<p>Please update to Safari 16.6+, or switch to Firefox or Chrome.</p>
<p>
We believe you are currently using Safari {browserVersion}.
If this is incorrect, please{' '}<Link
href="https://github.com/obi1kenobi/trustfall/issues/new"
target="_blank"
rel="noreferrer"
>let us know</Link>.
</p>
</Typography>
</Box>
</PlaygroundNonIdealState>
);
}
}

if (!ready) {
Expand Down
Loading