Support indexes, add Index and Unique annotation #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperty) The tests keep exploding with this though: ObjectBoxException: failed to create store: 10501 No index ID/UID assigned for indexed property: Property uByte (15, Byte) Even objectbox-model.json seems normal.
…ing apart @unique and @Index are sharing the same logic.
After turning them off this popped beautiful gem up: ObjectBoxException: failed to create store: 10001 State condition failed in assignIdsForProperty:476: indexId <= catalog.lastIndexId()
|
Unrequested review: I think my |
|
@Buggaboo Yeah, thanks. This is not done, yet. Hence the draft status. |
# Conflicts: # generator/lib/src/entity_resolver.dart # lib/src/annotations.dart # lib/src/bindings/bindings.dart # lib/src/bindings/signatures.dart # lib/src/modelinfo/modelentity.dart # lib/src/modelinfo/modelproperty.dart # lib/src/util.dart # test/entity.dart
vaind
force-pushed
the
Buggaboo-feature/annotation-candy
branch
from
116069a to
7577849
Compare
vaind
force-pushed
the
Buggaboo-feature/annotation-candy
branch
from
7577849 to
859ba5d
Compare
|
Fixed issues, added tests and cleaned up. fast-tracking this to get on with other PRs but please have a look at the changes @greenrobot-team |
|
@vaind Invalid usages of the annotations and index type are not tested, otherwise LGTM. Thanks for finishing this! (You even caught all TODOs and left-over code removals!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #120
Making progress.
Overall I'm not sure if there should be separate annotations vs. using flags on the existing
@Propertyannotation.