added utf8 support #14
Conversation
|
Thanks for your PR - and congrats to the do the first one ever in this project! 🥇 We'll look into it very soon. |
lib/src/box.dart
Outdated
| @@ -125,25 +125,25 @@ class Box<T> { | |||
| } | |||
|
|
|||
| // transform flatbuffers byte array into memory area for C, with a length of a multiple of four | |||
| Pointer<Uint8> bufferPtr = allocate(count: ((buffer.length + 3.0) / 4.0).toInt() * 4); | |||
| Pointer<Uint8> bufferPtr = Pointer<Uint8>.allocate(count: ((buffer.length + 3.0) / 4.0).toInt() * 4); | |||
There was a problem hiding this comment.
I'm getting compile errors with those:
lib/src/common.dart:8:50: Error: Method not found: 'Pointer.allocate'.
Pointer<Int32> majorPtr = Pointer<Int32>.allocate(), minorPtr = Pointer<Int32>.allocate(), patchPtr = Pointer<Int32>.allocate();
^^^^^^^^
What's your Dart version?
$ dart --version
Dart VM version: 2.4.1
Maybe we have to increase the Dart version requirement?
There was a problem hiding this comment.
I can confirm @greenrobot's error. If you look at the Dart FFI source file at /usr/lib/dart/lib/ffi/ffi.dart on Linux, you can see that the allocate function is not a static member or constructor of the Pointer class, but just outside of it.
Yet, the FFI SQLite example uses Pointer.allocate as well, despite the underlying source file clearly being different.
Additionally, the master branch of the Dart SDK contains Pointer.allocate in the correct form, see here. This means that either the Dart PPA is deprecated (which is unlikely, as dart --version correctly says 2.4.1 on my machine) or Pointer.allocate is a recent change not yet part of a Dart release, but already in its master branch.
There was a problem hiding this comment.
$ dart --version
Dart VM version: 2.5.0-dev.2.1 (Thu Aug 15 16:05:39 2019 +0200) on "macos_x64"I drink what homebrew offers me.
There was a problem hiding this comment.
Uh, so FFI plans to change that!? Is there any way to support both version? If we cannot make this work for both, I think we should stick to the latest release version.
There was a problem hiding this comment.
I reverted the parts that are related to the fromAddress and allocate methods. That specific commit can be (re)reverted once 2.5 is the new stable.
this triggered some weird compiler errors. Then I tried this without explicitly casting, evidently there's some type polymorphism going on, or some casting by the compiler. In any case, the Uint8List has been removed.
TODO Revert and test this commit when 2.5 is released as stable
|
Great! Unfortunately the folder structure for the next version of this binding (0.2), currently in the |
Changes
fromAddressandallocatemethods.