Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced CString with ffi utf util package #21

Merged
merged 4 commits into from
Sep 14, 2019
Merged

Replaced CString with ffi utf util package #21

merged 4 commits into from
Sep 14, 2019

Conversation

Buggaboo
Copy link
Contributor

@Buggaboo Buggaboo commented Sep 13, 2019 •
edited
Loading

Fix for issue #17

vaind
vaind reviewed Sep 13, 2019
View reviewed changes
Copy link
Contributor

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good, I just had a few suggestions. What do you think?

lib/src/common.dart Show resolved Hide resolved
lib/src/common.dart Show resolved Hide resolved
lib/src/model.dart Outdated Show resolved Hide resolved
lib/src/model.dart Outdated Show resolved Hide resolved
lib/src/model.dart Outdated Show resolved Hide resolved
lib/src/store.dart Outdated Show resolved Hide resolved
@vaind
Copy link
Contributor

vaind commented Sep 14, 2019

thanks again, merging 👍

@vaind vaind merged commit 8c96861 into objectbox:dev Sep 14, 2019
@Buggaboo Buggaboo deleted the utf8 branch October 2, 2019 07:05
@FredJul FredJul mentioned this pull request Sep 22, 2021
Closed
greenrobot-team added a commit that referenced this pull request Feb 20, 2023
@greenrobot-team
objectbox: require Dart SDK 2.17 to use NativeFinalizer #21
a6597c3
greenrobot-team added a commit that referenced this pull request Feb 21, 2023
@greenrobot-team
objectbox: require Dart SDK 2.17 to use NativeFinalizer #21
72cfaa0
greenrobot-team added a commit that referenced this pull request Mar 14, 2023
@greenrobot-team
Revert "objectbox: require Dart SDK 2.17 to use NativeFinalizer #21"
65c129f 
This reverts commit 72cfaa0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaind vaind vaind left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Buggaboo @vaind