Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP query #27

Merged
merged 72 commits into from
Oct 21, 2019
Merged

WIP query #27

merged 72 commits into from
Oct 21, 2019

Conversation

Buggaboo
Copy link
Contributor

@Buggaboo Buggaboo commented Oct 3, 2019 •
edited
Loading

Last hurdle: fixing the tests, take inspiration from the golang tests.

@Buggaboo
Implement query and builder related ffi functions
88dd2d3 
except

obx_qb_link_property
obx_qb_backlink_property
obx_qb_link_standalone
obx_qb_backlink_standalone
@Buggaboo
at least op overloading is working...
bb470cd
@Buggaboo
minor typo
bd7a32e
@Buggaboo
another attempt to fix the test
a8c849b 
weird NPE issue
@Buggaboo
focus, do aliases later
26e5b33
@Buggaboo
streamline enums
39e6a8c
@Buggaboo
Finalized query condition design, also got tests running
e820156
@Buggaboo
added operator overloads for int properties
15e9b7a
@Buggaboo
added queryAny and queryAll to the box
7698354
@Buggaboo
added contains / contain to the party
23bb90f
@Buggaboo
added close to new queries
004bcd2
@Buggaboo
updated dummy type for isNull / notNull
07a5059
@Buggaboo
cleaned up tests
0d2e907
@Buggaboo
added tests for double and booleans (both are not supported atm)
2b3b91b
@Buggaboo
added implementation and tests for in, notIn, greater, less
0b19c16
@Buggaboo
updated test for contain and contains for String
b14c10c
@Buggaboo
* Modified function signature of find find_ids, maybe unnecessary
b9c5189 
* Reused IDArray to read findIds values
* Added generics to Query, QueryBuilder
* Implement findIds
@Buggaboo
Merge branch 'query' into dev-query
e81d351
@Buggaboo
minor cleanup
6690bd2
@Buggaboo
updated readme
231c781
@Buggaboo
forgot symbol associativity
e80fe14
@Buggaboo
added bool and double to supported types, still segfaulting on isNull…
42f1152 
… notNull test
@Buggaboo
try finally resource release
b9ae9d9
@vaind vaind changed the title Dev query WIP query Oct 9, 2019
vaind
vaind reviewed Oct 9, 2019
View reviewed changes
Copy link
Contributor

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just had a few suggestions about structuring and simplifying the code.

README.md Outdated Show resolved Hide resolved
test/box_test.dart Outdated Show resolved Hide resolved
lib/src/query.dart Outdated Show resolved Hide resolved
lib/src/bindings/signatures.dart Show resolved Hide resolved
lib/src/query.dart Outdated Show resolved Hide resolved
lib/src/bindings/structs.dart Outdated Show resolved Hide resolved
lib/src/query.dart Outdated Show resolved Hide resolved
lib/src/query.dart Outdated Show resolved Hide resolved
lib/src/query.dart Outdated Show resolved Hide resolved
lib/src/annotations.dart Show resolved Hide resolved
@vaind vaind mentioned this pull request Oct 15, 2019
Merged
vaind
vaind reviewed Oct 15, 2019
View reviewed changes
Copy link
Contributor

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments, some I've ended up addressing in the PR related to OBX_id_array ffi struct. See Buggaboo#1

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
bin/objectbox_model_generator/lib/src/code_chunks.dart Show resolved Hide resolved
bin/objectbox_model_generator/lib/src/code_chunks.dart Outdated Show resolved Hide resolved
test/query_test.dart Outdated Show resolved Hide resolved
lib/src/query/query.dart Outdated Show resolved Hide resolved
lib/src/query/query.dart Outdated Show resolved Hide resolved
lib/src/query/query.dart Outdated Show resolved Hide resolved
lib/src/bindings/signatures.dart Show resolved Hide resolved
lib/src/bindings/signatures.dart Show resolved Hide resolved
@vaind vaind merged commit e693c07 into objectbox:dev Oct 21, 2019
@vaind
Copy link
Contributor

vaind commented Oct 21, 2019

I've merged this, doing a couple of small changes in the process

  • reverted the double equals() for now to prevent users assuming it actually works 100 % correctly
  • added tests to make sure conditions are combined together as expected
  • formatted
  • updated the generator test case

@Buggaboo
Copy link
Contributor Author

Omg! Let's do a beer some time to celebrate.

@Buggaboo Buggaboo deleted the dev-query branch October 21, 2019 14:45
@FredJul FredJul mentioned this pull request Sep 22, 2021
Closed
greenrobot-team added a commit that referenced this pull request Jan 31, 2024
@greenrobot-team
Android 6: call compat native lib loading for all Flutter apps #27
b93ac43 
Note: Flutter plugin method is only called on Android, also is a no-op
on devices newer than Android 6 (API level M).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaind vaind vaind left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Buggaboo @vaind