Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implemented write transactions #50

Merged
merged 6 commits into from
Oct 23, 2019
Merged

implemented write transactions #50

merged 6 commits into from
Oct 23, 2019

Conversation

liquidiert
Copy link
Contributor

This addresses #34.
Should be working 👍 Let me know if something is wrong or should be changed :)

vaind
vaind suggested changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks having a go at this 👍 There are a couple of things to handle yet.

lib/src/store.dart Outdated Show resolved Hide resolved
test/box_test.dart Show resolved Hide resolved
@vaind
Copy link
Contributor

vaind commented Oct 23, 2019

Yeah, and we should also start including method-level docs... I need to write up that contributing.md...

@liquidiert
Copy link
Contributor Author

Should I add some doxy comments then?

@vaind
Copy link
Contributor

vaind commented Oct 23, 2019

Should I add some doxy comments then?

Yes, for the store method if you could. Like this: https://dart.dev/guides/language/effective-dart/documentation#do-use--doc-comments-to-document-members-and-types

@liquidiert
Copy link
Contributor Author

Of course 👍

vaind
vaind reviewed Oct 23, 2019
View reviewed changes
lib/src/store.dart Outdated Show resolved Hide resolved
test/box_test.dart Outdated Show resolved Hide resolved
@vaind vaind merged commit 6ec433d into objectbox:dev Oct 23, 2019
@FredJul FredJul mentioned this pull request Sep 22, 2021
Closed
greenrobot-team added a commit that referenced this pull request Mar 6, 2023
@greenrobot-team
Async APIs: add Box.getAsync, getManyAsync and getAllAsync #50
b795648
greenrobot-team added a commit that referenced this pull request Mar 6, 2023
@greenrobot-team
Async APIs: add Query.findAsync #50
c61998c
greenrobot-team added a commit that referenced this pull request Mar 6, 2023
@greenrobot-team
draft Async APIs: replace putAsync implementation with runAsync #50
91ee316
greenrobot-team added a commit that referenced this pull request Mar 6, 2023
@greenrobot-team
draft Async APIs: restore old putAsync implementation #50
4a82584
greenrobot-team added a commit that referenced this pull request Mar 6, 2023
@greenrobot-team
draft Async APIs: update tests #50
70378ff
greenrobot-team added a commit that referenced this pull request Mar 6, 2023
@greenrobot-team
fix formatting #50
90450af
greenrobot-team added a commit that referenced this pull request Mar 6, 2023
@greenrobot-team
Async APIs: add putAsync2 implementation with runAsync #50
2e1d4fb
greenrobot-team added a commit that referenced this pull request Mar 7, 2023
@greenrobot-team
Async APIs: add Box.getAsync, getManyAsync and getAllAsync #50
f2dc058
greenrobot-team added a commit that referenced this pull request Mar 7, 2023
@greenrobot-team
Async APIs: add Query.findAsync #50
44c7f3e
greenrobot-team added a commit that referenced this pull request Mar 7, 2023
@greenrobot-team
Async APIs: new putAsync, rename old to putQueuedAwaitResult #50
934ec72
greenrobot-team added a commit that referenced this pull request Mar 7, 2023
@greenrobot-team
Async APIs: add putManyAsync to Box #50
de25b15
greenrobot-team added a commit that referenced this pull request Mar 7, 2023
@greenrobot-team
Async APIs: rename Store await APIs to avoid mix-up with async #50
541575c
greenrobot-team added a commit that referenced this pull request Mar 7, 2023
@greenrobot-team
Async APIs: update benchmarks for putQueued #50
9e1007c
greenrobot-team added a commit that referenced this pull request Mar 14, 2023
@greenrobot-team
Async APIs: add Query.findAsync #50
f06cee8
greenrobot-team added a commit that referenced this pull request Mar 14, 2023
@greenrobot-team
Async APIs: new putAsync, rename old to putQueuedAwaitResult #50
0eb67c3
greenrobot-team added a commit that referenced this pull request Mar 14, 2023
@greenrobot-team
Async APIs: rename Store await APIs to avoid mix-up with async #50
b0aecae
greenrobot-team added a commit that referenced this pull request Mar 14, 2023
@greenrobot-team
Async APIs: add putManyAsync to Box #50
cebada1
greenrobot-team added a commit that referenced this pull request Mar 14, 2023
@greenrobot-team
Async APIs: add putAndGet variants, let put not modify given objects #50
f5e056d
greenrobot-team added a commit that referenced this pull request Mar 14, 2023
@greenrobot-team
Async APIs: extract common count for benchmarks #50
8f8e4c0
greenrobot-team added a commit that referenced this pull request Mar 14, 2023
@greenrobot-team
Async APIs: add Box.getAsync, getManyAsync and getAllAsync #50
3f3275c
greenrobot-team added a commit that referenced this pull request Mar 14, 2023
@greenrobot-team
Async APIs: add Query.findAsync #50
170102b
greenrobot-team added a commit that referenced this pull request Mar 14, 2023
@greenrobot-team
Async APIs: new putAsync, rename old to putQueuedAwaitResult #50
539f100
greenrobot-team added a commit that referenced this pull request Mar 14, 2023
@greenrobot-team
Async APIs: rename Store await APIs to avoid mix-up with async #50
3d1f97b
greenrobot-team added a commit that referenced this pull request Mar 14, 2023
@greenrobot-team
Async APIs: add putManyAsync to Box #50
8e3b0c5
greenrobot-team added a commit that referenced this pull request Mar 14, 2023
@greenrobot-team
Async APIs: add putAndGet variants, let put not modify given objects #50
68ba73e
greenrobot-team added a commit that referenced this pull request Mar 14, 2023
@greenrobot-team
Async APIs: extract common count for benchmarks #50
acb28cd
greenrobot-team added a commit that referenced this pull request Mar 14, 2023
@greenrobot-team
objectbox: require Dart SDK 2.15 to use constructor-tearoffs #50
e749e9a
greenrobot-team added a commit that referenced this pull request Mar 14, 2023
@greenrobot-team
Async APIs: add Box.getAsync, getManyAsync and getAllAsync #50
4787515
greenrobot-team added a commit that referenced this pull request Mar 14, 2023
@greenrobot-team
Async APIs: add Query.findAsync #50
fdb0709
greenrobot-team added a commit that referenced this pull request Mar 14, 2023
@greenrobot-team
Async APIs: new putAsync, rename old to putQueuedAwaitResult #50
3b18bcc
greenrobot-team added a commit that referenced this pull request Mar 14, 2023
@greenrobot-team
Async APIs: rename Store await APIs to avoid mix-up with async #50
ba6774a
greenrobot-team added a commit that referenced this pull request Mar 14, 2023
@greenrobot-team
Async APIs: add putManyAsync to Box #50
500c5a0
greenrobot-team added a commit that referenced this pull request Mar 14, 2023
@greenrobot-team
Async APIs: add putAndGet variants, let put not modify given objects #50
016ddf7
greenrobot-team added a commit that referenced this pull request Mar 14, 2023
@greenrobot-team
Async APIs: extract common count for benchmarks #50
8732034
greenrobot-team added a commit that referenced this pull request Mar 14, 2023
@greenrobot-team
Async APIs: use in relations example #50
5ab8a4e
greenrobot-team added a commit that referenced this pull request Mar 20, 2023
@greenrobot-team
Async APIs: add async remove methods to Box #50
f07f8b2
greenrobot-team added a commit that referenced this pull request Mar 20, 2023
@greenrobot-team
Async APIs: add async remove method to Query #50
2bcadaa
greenrobot-team added a commit that referenced this pull request Mar 20, 2023
@greenrobot-team
Async APIs: use in examples #50
7378dae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaind vaind vaind requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liquidiert @vaind