-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - support for dart26 #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could have used extension methods to fix it without changing too many lines of code
replace allocate/free with package:ffi's
used asTypedList properly
since there is no clear connection between the alloc of Uint8 and the Utf8 Struct At least we can generate, compile, run all the tests
Closed
|
pana takes the
Hmm, what does that help with? |
Actually nothing really, just shortly during development right now, because the current regular |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant changes since 2.6
Struct<T>
toStruct
ref
free
andallocate
are part ofpackage:ffi
as independent functionsload
andstore
became a getter/setter calledvalue
elementAt
has indexing syntax-sugar i.e.ptr[i]
asTypedList
to create dart native list typesUpdate
free(someUtf8Instance)
does the job, sinceUtf8 extends Struct
and does not clearly address theUint8
allocation.attachFinalizer
is available, and hook onfree
from there. (TODO anyone else other than me)At least everything generates, compiles, and the coverage is back to 100%.
This addresses Issue #54
Sources: